dizda / CloudBackupBundle

Be able to backup your database(s) and upload it to the cloud (Dropbox, Amazon S3, GoogleDrive, etc.)
MIT License
196 stars 57 forks source link

Introduced a processor manager #54

Closed Nyholm closed 9 years ago

Nyholm commented 9 years ago

We don't need all logic in all processors.

Ping #51

Nyholm commented 9 years ago

I rewrote the command and added some neat messages.

dizda commented 9 years ago

Ok it's better like this.

dizda commented 9 years ago

Great job bro.

Nyholm commented 9 years ago

Thank you for merging. This bundle takes looks better and better.

You could consider to merge the compliler passes into one. You may also want to write log entries before each step in BackupManager::execute.

Then of course a clean up of all the code that are hidden in comments.

dizda commented 9 years ago

What are the advantages to merge the compiler passes into one?

You may also want to write log entries before each step in BackupManager::execute. => Yes

And there are also a lot of tests to update and improve.

Nyholm commented 9 years ago

There is no advantages but 2 less classes to load. There is however no reson to separate them. (It is not a big issue at all, but since you are rewriting and cleaning up everything it thought "Why not")

dizda commented 9 years ago

Ok good point

dizda commented 9 years ago

BTW @Nyholm, I have this error:

$ sf dizda:backup:start -vvv
PHP Fatal error:  Call to undefined method Dizda\CloudBackupBundle\Manager\ProcessorManager::getExtension() in /Users/dizda/www/dizdabundles/vendor/dizda/cloud-backup-bundle/Dizda/CloudBackupBundle/Manager/ProcessorManager.php on line 129
Nyholm commented 9 years ago

Okey. It should be $this->processor->getExtension()

On 19 feb 2015, at 17:55, Jonathan Dizdarevic notifications@github.com wrote:

BTW @Nyholm, I have this error:

$ sf dizda:backup:start -vvv PHP Fatal error: Call to undefined method Dizda\CloudBackupBundle\Manager\ProcessorManager::getExtension() in /Users/dizda/www/dizdabundles/vendor/dizda/cloud-backup-bundle/Dizda/CloudBackupBundle/Manager/ProcessorManager.php on line 129 — Reply to this email directly or view it on GitHub.

dizda commented 9 years ago

Thanks