dizda / CloudBackupBundle

Be able to backup your database(s) and upload it to the cloud (Dropbox, Amazon S3, GoogleDrive, etc.)
MIT License
196 stars 57 forks source link

Added splitter as a service #60

Closed Nyholm closed 9 years ago

Nyholm commented 9 years ago

Added splitter as a service. Make sure we use the config parameters to set split_size.

ndoulgeridis commented 9 years ago

Get this error

[2015-03-18 13:42:01] app.CRITICAL: [dizda-backup] Unexpected exception. {"exception":"[object]

(Exception(code: 268567041): File '...../cache/dev/backup/../backup_compressed/milhaud_2015-03-18_13-40-46.zip' too large (377946829 bytes). at ...../vendor/hakre/dropbox-uploader/DropboxUploader.php:108)"} []

Seems now doesn't try to upload split files but main file. Checking...

ndoulgeridis commented 9 years ago

The splitter creates *_parts files, this should be passed to file services (dropbox, google drive etc) and not the original one.

Nyholm commented 9 years ago

Got it.. updating in a minute

ndoulgeridis commented 9 years ago

nice!

Nyholm commented 9 years ago

The drawback of this solution is that client authentication must be done for every part of the archive.

An alternative solution is to make sure the clients can accept a list of files and make each client try to optimize the upload process. But IMHO is client authentication a small fractions of the total time for the backup process.

ndoulgeridis commented 9 years ago

Hmm yes indeed but I don't know if clients allow multi file uploading at once, need to research but as you already mentioned the way it is implemented now wont hurt performance too much.

ndoulgeridis commented 9 years ago

Works fine btw!!!!

Nyholm commented 9 years ago

Okey, Great. Thank you.

dizda commented 9 years ago

Great, so the splitter is now working fine? So we should write missing tests, and we'll be able to merge into master then release the new version.

ndoulgeridis commented 9 years ago

Yes in my copy seems working fine, it successfully uploaded a split backup to Dropbox

Nyholm commented 9 years ago

Thank you for merging

dizda commented 9 years ago

Thanks for this fast PR @Nyholm and reviews @crash21