search

dizda / CloudBackupBundle

Be able to backup your database(s) and upload it to the cloud (Dropbox, Amazon S3, GoogleDrive, etc.)
MIT License
196 stars 57 forks source link

Add more setters #75

Closed chesedo closed 8 years ago

chesedo commented 8 years ago

I have a instance were I am injecting the BackupManager into a service, but need to have separate settings for the Backups when using the terminal command. This service will also need to change some settings dynamically (especially the folders to backup) which is not currently possible - even tried to inject the container, but cannot modify parameters from within a service.

So the Manager classes are extended (setter and getter methods added) to be able to change some of the properties I need to change in the class. Also added other setters that future users might need to change a few properties.

dizda commented 8 years ago

Good idea, thanks for the PR! :+1:

chesedo commented 8 years ago

Thanks for accepting the PR :smile:

A note... I had a lot of trouble when I was trying to inject the backupManager since I saw in the code that it is registered as a service. After awhile I realized that v1.6 did not have this feature while the code I was looking at (v2.1) did. Is there a reason why the readme has instructions to install v1.6 and not the latest?

dizda commented 8 years ago

Hey @pieter2627, Indeed we made a huge refactoring for the v2. Which part of the README is not up to date?

Thanks

chesedo commented 8 years ago

Under Installation => Composer it has ~1.6 (I am not up-to-date with how composer works so am not sure what the wave/tilde signifies)

dizda commented 8 years ago

Oh yeah right, I just removed the version constraint! Thanks to have noticed it!