search

dizda / CloudBackupBundle

Be able to backup your database(s) and upload it to the cloud (Dropbox, Amazon S3, GoogleDrive, etc.)
MIT License
196 stars 57 forks source link

Require php 5.4 or later #85

Closed jongotlin closed 7 years ago

jongotlin commented 8 years ago

Php 5.3 security support ended over a year ago. Not even 5.4 have active security support and maybe we should require 5.5+?

dizda commented 8 years ago

Agree. But I think we should not break compatibilities before the next major version, what do you think guys? cc. @Nyholm

Nyholm commented 8 years ago

I do not remember best practices here. Hm.. Some thoughts:

1) We should not remove PHP 5.3 because it old. We should remove it because we need to. (Like #86) 2) Symfony 2.8 LTS is supporting PHP 5.3.9 3) Symfony 3 LTS is supporting PHP 5.5.9 4) If we update our minimum php support and bump to version 3.2, nobody running PHP 5.3 will be effected. They can simply not install 3.2 and will automatically stick to 3.1.

Ocramius argues for the zend framework that:

it would be a BC break if it caused an upgrade to crash a system, but since we use composer to install packages nowadays, you simply cannot upgrade if requirements aren't met.

We still aren't changing API signatures.

My opinion it that we should do this if needed and if we do we should create a new minor version.

Nyholm commented 7 years ago

This PR is almost a year old. I just ran into issues on Travis on PHP 5.3.

I vote for dropping PHP 5.3 support. @dizda are you okey with merging this PR?

dizda commented 7 years ago

@Nyholm Definitely! I've merged #109. Shall we close this one?

Nyholm commented 7 years ago

Thank you Jon. These changes are merged by #109