search

dizda / CloudBackupBundle

Be able to backup your database(s) and upload it to the cloud (Dropbox, Amazon S3, GoogleDrive, etc.)
MIT License
196 stars 57 forks source link

Remove the old DropboxClient #91

Closed dizda closed 8 years ago

dizda commented 8 years ago

I propose to mark the old Dropbox client as @deprecated, then remove it for 4.0.0 release.

https://github.com/dizda/CloudBackupBundle/blob/master/Client/DropboxClient.php https://github.com/dizda/CloudBackupBundle/blob/master/DependencyInjection/Configuration.php#L52

What do you think guys?

dizda commented 8 years ago

Mainly because the authentification method is not appropriated, and very unstable. (see #76, #68)

Nyholm commented 8 years ago

+1 if we create an adapter for Flysystem

dizda commented 8 years ago

Actually, the OAuth method through the Dropbox SDK is already present here

But flysystem looks neat tho, and should be adapted to this bundle IMO.

Nyholm commented 8 years ago

Ah, I see. We got two Dropbox clients.

Yes I totally agree. We should deprecate the old one.