Feat/async trait auth - Githubissues

dizda / fast-socks5

Fast SOCKS5 client/server implementation written in Rust async/.await (with tokio)

https://anyip.io/

MIT License

340 stars 67 forks source link

Feat/async trait auth #37

Closed dizda closed 9 months ago

dizda commented 1 year ago

Based on the work of https://github.com/dizda/fast-socks5/pull/36 (thank you)

More flexibility has been added, such as

async_trait is being used, which makes it easier to use async fn for authentication
allow_no_auth flag, for scenario where we could auth the client via other parameters such as IP address, etc. so the client doesn't need to send credentials, but will be checked by the Authentication trait anyway.
user's account can be returned once the socket has been successfully upgraded to socks5 (hence successfully authenticated), so no need to use black magic anymore to do so

dizda commented 1 year ago

Feel free to review @nemosupremo

nemosupremo commented 1 year ago

Ah looks good, I was a bit confused on how you planned to return the users credentials and spent some time on that, but the get_credentials makes more sense.

Only thing I would add is maybe SimpleUserPassword should return an AuthenticationMethod::Password like struct so that users who might depend on AuthenticationMethod::Password with the username and password have a clear upgrade path.

dizda commented 1 year ago

Only thing I would add is maybe SimpleUserPassword should return an AuthenticationMethod::Password like struct so that users who might depend on AuthenticationMethod::Password with the username and password have a clear upgrade path.

Thanks for the feedback, I've updated the server example accordingly.

dizda commented 9 months ago

Released on 0.9.0