search

dizlexik / express-reverse

Express helper for generating reverse route URLs.
27 stars 7 forks source link

Support express 4.x's Router #4

Open felipap opened 10 years ago

felipap commented 10 years ago

I've been looking for a way to support reversing urls also in express.Router(), which I believe were introduced with express 4.0. There doesn't seem to be a way to achieve this simply by monkey patching the app once. Thoughts?

dizlexik commented 10 years ago

I have thought about this and I'd love to add support for express.Router() when I get the time. I'll keep this on my list and hopefully I can get around to it sooner than later. Also, PRs are always welcome :wink:

paulschwarz commented 9 years ago

sooner than later? ;)

dizlexik commented 9 years ago

Dude, chill, it's only been a year...

Haha, seriously though this obviously fell right off of my list, sorry :/ I'm not in any position to tackle this right now, or maybe ever since I haven't used express in a long while, but if you'd like to take a shot at this and submit a PR I'd gladly roll it in and publish a new version!

eugenioclrc commented 8 years ago

+1

kokujin commented 8 years ago

Hey there, is there an ETA on this feature?

dizlexik commented 8 years ago

Sorry, I'm still not planning on working on this. I haven't used express in forever and I don't have the time to update this. I'd be more than happy to merge in a PR if anyone wants to take a crack at it though.