Cleanup CraftTweaker integration code

pupnewfster commented 5 years ago

Did some work that should make parts of #16 easier to implement. Also lowered the amount of log spam. (The majority of the remaining log spam will be removed when Jared gets a chance to release a new version of MTLib)

Refactored the crafttweaker integration to remove duplicate code (It now relies on generics and a helper class instead)
Lowered the number of unchecked cast warnings down to 2
Improved the warning message for when no recipe of a given type was found.
Don't spam the CraftTweaker log with 0 recipes removed, when we already are showing a warning message for no recipes found.
Made CraftTweakerGasStack implement all methods that IIngredient declares in newer versions of CrT

dizzyd commented 5 years ago

This looks pretty good and I'm going to merge into 9.4.19, beta 1.

In the future if you would please avoid committing files that are ONLY variable name changes or formatting changes, that would be ideal - makes it hard to pick through the actual changes. :)

dizzyd commented 5 years ago

Merged.

pupnewfster commented 5 years ago

Ya sorry about that, some of the code when I was copy pasting things around deduplicating code was formatted strangely, so I just ran my formatter on the entire package forgetting that it would make the diff harder to read.

dizzyd commented 5 years ago

No worries. If you get a chance, please pull master and validate everything you changed is still working and also play around with sound a bit?

dizzyd / Mekanism

Cleanup CraftTweaker integration code #19