search

dizzyd / mcdex

Minecraft Modpack Management
Apache License 2.0
75 stars 8 forks source link

incorrect forge download url #10

Closed Spongman closed 7 years ago

Spongman commented 7 years ago 
2017/08/28 02:47:30 failed to install Forge 10.13.4.1614: failed to read Forge installer: zip: not a valid zip file

the generated url used to download forge is sometimes wrong depending on the version.

sometimes the correct location looks like this:

https://files.minecraftforge.net/maven/net/minecraftforge/forge/1.9-12.16.0.1886/forge-1.9-12.16.0.1886-universal.jar

and sometimes like this:

https://files.minecraftforge.net/maven/net/minecraftforge/forge/1.9-12.16.0.1885-1.9/forge-1.9-12.16.0.1885-1.9-installer.jar

note the duplicated MC versions.

dizzyd commented 7 years ago

Sigh. What version of forge did you really want installed? I'll use that as a test case.

It's so obvious that some forge releases are built by hand. Not sure why TF they would do this for something so widely used....
Spongman commented 7 years ago

i don't remember exactly which one. project ozone 2 was the modpack from curse, i believe. i checked a bunch of download URLs, it looks like they only use those two schemes.

dizzyd commented 7 years ago

I've tried to reproduce this but haven't been able to. If you have a specific modpack URL that's failing, please re-open this issue with that so I can reproduce and fix. :)

Spongman commented 7 years ago

project ozone 2 was the one. i gave you all the info you need to fix.

just attempt to download from the URL scheme you currently do, if that fails, try the other one. done.

dizzyd commented 7 years ago

@Spongman I couldn't find a Project Ozone 2 on curseforge - do you have the download link?

(there were a whole bunch of Project Ozone 2 (Reloaded, Lite, etc)) - I wasn't going to try every one. :)

Spongman commented 7 years ago

this is the one, i think: https://www.curseforge.com/minecraft/modpacks/project-ozone-2-reloaded

dizzyd commented 7 years ago

Fixed in v0.7.5. :) Thanks for the URL link.

Spongman commented 7 years ago

that still won't work for all forge versions.