search

dizzyd / mcdex

Minecraft Modpack Management
Apache License 2.0
75 stars 8 forks source link

Update to work with the new curseforge site #48

Closed mgziminsky closed 5 years ago

mgziminsky commented 5 years ago

Fix the urls used to download mods and packs from curseforge to use the correct paths for their new site.

For installing mods, I left it calling the old redirect, but don't know if that's going to work for long. I considered changing it to lookup the slug in the DB, but that's less reliable in case a mod isn't in the db for whatever reason. There does appear to be quite a few missing right now, so the db may be due for a full refresh.

Esgariot commented 5 years ago

I've just tried to download few mods using the latest release and instead of downloading .jars there were a bunch of webpages. Could it be that old curseforge paths are no longer correct?

mgziminsky commented 5 years ago

Yes, the current version is broken since the new curseforge site went live. That's what this PR is fixing.

You'll have to wait until this gets merged, or dizzyd releases his own fix.

If you know how, you can build my branch for yourself until an official release is ready.

Esgariot commented 5 years ago

I needed to remove everything from mods/ or it would skip, but except that worked like a charm. Thanks!

dizzyd commented 5 years ago

I'll dig into this tomorrow morning! Thanks for submitting.

Trolzer commented 5 years ago

any updates on getting this merged?

dizzyd commented 5 years ago

I’m traveling at the moment, but hope to get it done tomorrow!

Sent from my iPhone

On Jul 9, 2019, at 18:55, Trolzer notifications@github.com wrote:

any updates on getting this merged?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

dizzyd commented 5 years ago

Thank you @mgziminsky !! All merged in.