search

dizzyd / mcdex

Minecraft Modpack Management
Apache License 2.0
74 stars 8 forks source link

mcdex doesn't support the new forge site. #49

Closed Riku5543 closed 5 years ago

Riku5543 commented 5 years ago

This tool explicitly checks for minecraft.curseforge.com now, but the new url is just curseforge.com. This means it's impossible to download modpacks from Curse now.

Riku5543 commented 5 years ago

Also, even if I comment out the checks in modpack.go, the individual mods fail to download because of the new URL scheme.

Riku5543 commented 5 years ago

I found out the new link format for you to incorporate into your program. Modpack URL: https://www.curseforge.com/minecraft/modpacks/projectID/download/fileID/file Mod URL: https://curseforge.com/minecraft/mc-mods/projectID/download/fileID/file

Edit: After patching out the checks in download (modpack.go) and changing the URL in installMod (modpack.go), all of the mod files download successfully. The way I did it was pretty hacky, as it removes the safety checks, but otherwise the new system could be implemented.

Bockiii commented 5 years ago

Hi,

I can see that you made the commits, but the released linux version still has the issue. Do you need to kick off the build for that?

Bockiii commented 5 years ago

Is it possible that you missed a spot in the db.go?

// Construct a URL using the slug and file ID
    return fmt.Sprintf("https://minecraft.curseforge.com/projects/%d/files/%d/download", pid, fileID), nil;
Riku5543 commented 5 years ago

Ah, I'm not the one who did a pull request or any commits. I simply changed the code locally and used it that way. Sorry about that.

Bockiii commented 5 years ago

I meant @dizzyd :) I just hijacked your issue because it was the latest about curseforge not working :)

dizzyd commented 5 years ago

So, my git got messed up -- which is part of the problem. There is another problem that I'm still working through. Hope to have it fixed today. :/

dizzyd commented 5 years ago

Ok, 0.9.7 is out that fixes all these problems. Let me know if it breaks again!

lpuv commented 4 years ago

I have the same issue with macos

53