search

dj-wasabi / ansible-telegraf

Installing and configuring Telegraf via Ansible for RedHat/Debian/Ubuntu/Windows/Suse.
MIT License
134 stars 116 forks source link

Added property telegraf_agent_docker_image_version for using a specific version of the Docker image #137

Closed dj-wasabi closed 4 years ago

dj-wasabi commented 4 years ago

Added property telegraf_agent_docker_image_version for using a specific version of the Docker image

Description of PR

Type of change

Bugfix Pull Request

Fixes an issue

dj-wasabi commented 4 years ago

Hi @jgeusebroek

I added a property named telegraf_agent_docker_image_version which defaults uses the value from telegraf_agent_version but can be set to an other tag like latest.

Can you check if this works for you?

Kind regards, Werner

jgeusebroek commented 4 years ago

Awesome Werner, I will test it tonight!

jgeusebroek commented 4 years ago

Seems to be working fine! I made something that fetched the current version from the docker image. https://github.com/jgeusebroek/ansible-telegraf/tree/docker_version

But in the end it doesn't matter because there is no docker telegraf image < 0.10 :joy:.

dj-wasabi commented 4 years ago

@jgeusebroek haha! LOL

Thanks for testing, I'll merge this PR. 👍