First of all, thanks for the great solution, it saved me a huge headache in the first place. I would appreciate a thorough review as I am just dabbling with Ansible.
The molecule tests run successfully for me.
Description of PR
This PR improves the Windows installation by getting rid of the flag file and checking if the service is in place. Also it will compare the version of the desired installation and the current version of the machine. If it does match, it will leave the installation in peace, otherwise it will update the system. The change also contains log rotation for the Windows machines, which was unavaiable at the time of the telegraf version 1.10
Type of change
Feature Pull Request
Fixes an issue
It will fix a small issue with the unzipping/installation which can end up in a double "telegraf" path due to the archive having the same folder inside. Changed the path/default for this
dj-wasabi
commented
3 years ago
First of all, thanks for the great solution, it saved me a huge headache in the first place. I would appreciate a thorough review as I am just dabbling with Ansible. The molecule tests run successfully for me.
Description of PR This PR improves the Windows installation by getting rid of the flag file and checking if the service is in place. Also it will compare the version of the desired installation and the current version of the machine. If it does match, it will leave the installation in peace, otherwise it will update the system. The change also contains log rotation for the Windows machines, which was unavaiable at the time of the telegraf version 1.10
Type of change Feature Pull Request
Fixes an issue