search

dj-wasabi / ansible-telegraf

Installing and configuring Telegraf via Ansible for RedHat/Debian/Ubuntu/Windows/Suse.
MIT License
134 stars 116 forks source link

update influxdata GPG key after rotation #165

Closed Tetha closed 1 year ago

Tetha commented 1 year ago

Description of PR

This PR updates the apt_key to the newly rotated influxdata key. I've tested the change by locally modifying your galaxy role to the new key and then my molecule checks run again.

Type of change

Bugfix Pull Request

Fixes an issue

This fixes #164

fastman commented 1 year ago

@Tetha Why not influxdata-archive_compat.key as per https://www.influxdata.com/blog/linux-package-signing-key-rotation/?

Tetha commented 1 year ago

@fastman well, the page says:

What is the difference between influxdata-archive.key and influxdata-archive_compat.key?

The influxdata-archive.key signing key utilizes a modern primary/subkey approach that will be incorporated into future Linux packaging updates. The influxdata-archive_compat.key can verify packages signed with the influxdata-archive.key and has the widest APT and RPM compatibility. Please use the influxdata-archive_compat.key at this time.

So I've been looking around a bit, and this has been supported by apt and gpg for a long time, hence I figured to use the thing that's the desired, future looking solution instead of a compat workaround.

If the tests fail or more concerns appear, I can change it, but that'll incur another change down the road once the compat layer gets removed or changed.

dj-wasabi commented 1 year ago

I updated the master branch, can you rebase from master and retry?

dj-wasabi commented 1 year ago

Thanks! (I'll remove Debian 8 as it seems eol).

fastman commented 1 year ago

@dj-wasabi Can you create a new release as well? That would be great!

dj-wasabi commented 1 year ago

Hey @fastman I created tag 0.14.0