dj-wasabi / ansible-zabbix-agent

Installing and maintaining zabbix-agent for RedHat/Debian/Ubuntu/Windows/Suse.
https://galaxy.ansible.com/dj-wasabi/zabbix-agent
MIT License
327 stars 248 forks source link

Defining different jmx port number to configuring firewall #227

Closed 0utsider closed 5 years ago

0utsider commented 5 years ago

Improvement: defining different jmx port number - variable: (zabbix_agent_jmx_listenport)

Description of PR jmx port in zabbix_host module has define to: 12345. I adding different variable (zabbix_agent_jmx_listenport) to define own jmx port to configuring firewall rules.

Type of change Feature Pull Request

dj-wasabi commented 5 years ago

Should this not be part of the ansible-zabbix-javagateway Ansible role? (https://github.com/dj-wasabi/ansible-zabbix-javagateway)

0utsider commented 5 years ago

Maybe, but not necessary. You don't need install zabbix java gateway, to monitoring some parameters of java application. You can take parameters immediately from java application. That's why I decided to improve this role.

This improvement has no negative effects, but it gives you the opportunity to use this role more effectively.

dj-wasabi commented 5 years ago

Ok, thank you! 👍