search

dj-wasabi / ansible-zabbix-agent

Installing and maintaining zabbix-agent for RedHat/Debian/Ubuntu/Windows/Suse.
https://galaxy.ansible.com/dj-wasabi/zabbix-agent
MIT License
327 stars 248 forks source link

A bunch of performance tweaks #277

Closed drwahl closed 4 years ago

drwahl commented 5 years ago

I haven't verified this doesn't break Windows, but it fixes things like the Windows tasks being applied (skipped, technically) on Linux hosts, which in turn increases the performance of this role a ton. Along with a couple other small tweaks, I took the runtime of this role from 45s down to 17s.

Description of PR Performance enhancements for this role

Type of change Feature Pull Request

dj-wasabi commented 5 years ago

Hi @drwahl

I think you need to do a git pull origin master in your current branch and reapply/fix the changes. It seems you have created the perftweaks branch on a dated master branch and is causing merge conflicts.

May the force be with you (fixing merge issue 😉)!

drwahl commented 5 years ago

Oof... you are correct. I'm just about to head out of town, but I'll try to shore up this PR early next week.

drwahl commented 4 years ago

Life and work have gotten busy. I still intend to rebase my changes. Sorry for the delay.

dj-wasabi commented 4 years ago

No worries @drwahl , take your time! 👍

dj-wasabi commented 4 years ago

Hi @drwahl

Are you able to resolve these issues soon? This repository will be closed soon, as it will be migrated to the Ansible Zabbix collection on a different namespace.

drwahl commented 4 years ago

Go ahead and migrate this code base. I'll need to re-work my patchset and haven't had time to focus on this lately.