Description of PR
Move up task 'Override architecture if 64-bit'
The fact 'windows_arch' is set to 32 per default line 10.
The fact 'windows_arch' is used by "Windows | Set path to zabbix.exe" task juste after, so the path zabbix_win_exe_path contain 32bit path. And the override is after.
If we keep the override set_fact after this task : the path 'zabbix_win_exe_path' is not changed and keep this value to 32. And zabbix-agent in 64bit is never installed even if ansible_architecture is 64bit.
Type of change
Move up task 'Override architecture if 64-bit' to override 'windows_arch' value before use it.
Fixes an issue
The issue is not visible by ansible. But the main issue is : if the OS archi is 64bit, the version of zabbix-agent version 32bit is always installed.
After the change :
Before it was 'win32'.
Tested with Ansible 2.9.0 on Windows 2016 Server.
dj-wasabi
commented
4 years ago
Description of PR Move up task 'Override architecture if 64-bit' The fact 'windows_arch' is set to 32 per default line 10. The fact 'windows_arch' is used by "Windows | Set path to zabbix.exe" task juste after, so the path zabbix_win_exe_path contain 32bit path. And the override is after. If we keep the override set_fact after this task : the path 'zabbix_win_exe_path' is not changed and keep this value to 32. And zabbix-agent in 64bit is never installed even if ansible_architecture is 64bit.
Type of change Move up task 'Override architecture if 64-bit' to override 'windows_arch' value before use it.
Feature Pull Request Bugfix Pull Request Docs Pull Request
Fixes an issue The issue is not visible by ansible. But the main issue is : if the OS archi is 64bit, the version of zabbix-agent version 32bit is always installed.
After the change :
Before it was 'win32'. Tested with Ansible 2.9.0 on Windows 2016 Server.