dj-wasabi / ansible-zabbix-agent

Installing and maintaining zabbix-agent for RedHat/Debian/Ubuntu/Windows/Suse.
https://galaxy.ansible.com/dj-wasabi/zabbix-agent
MIT License
327 stars 249 forks source link

TLS Settings not working on Zabbix 3.2 #55

Closed frennkie closed 7 years ago

frennkie commented 7 years ago

I just started using this Ansible Role for my Zabbix 3.2 installation and noticed that none of the TLS settings are writen to the zabbix_agentd.conf file. As I won't be going back to anything older than Zabbix 3.0 I removed the version check: https://github.com/dj-wasabi/ansible-zabbix-agent/blob/master/templates/zabbix_agentd.conf.j2#L228

But it might be good if you could fix this in the role (also for people on <3.0).

frennkie commented 7 years ago

This change seems to address the same issue: https://github.com/chibacityblues/ansible-zabbix-agent/commit/cb5c50c21decf134faab30792a4686e23720f8fe

dj-wasabi commented 7 years ago

Thanks, will take a look at it.

dj-wasabi commented 7 years ago

I just pushed an fix for this to Github. Can you validate if this works?

frennkie commented 7 years ago

I already copied @chibacityblues solution which uses https://docs.ansible.com/ansible/playbooks_tests.html#version-comparison and is working for me. But from looking at your changes that should also work... it'll give it a try later on.

willwh commented 7 years ago

Hey @dj-wasabi thanks for your work on this, it was really helpful.

I can confirm that your changes in your master branch do not work with Zabbix 3.2, at all, the agent is deployed without any TLS configuration if supplied.

As mentioned though; https://github.com/chibacityblues/ansible-zabbix-agent/commit/cb5c50c21decf134faab30792a4686e23720f8fe works beautifully. (Which is what I'm using now)

dj-wasabi commented 7 years ago

Is this still an issue? Since this morning, the role uses the version_compare filter.

chibacityblues commented 7 years ago

I don't think so - my PR got merged a few weeks back.

dj-wasabi commented 7 years ago

Ok, thank you. Will close this issue.