search

dj-wasabi / ansible-zabbix-server

Installing and maintaining zabbix-server for RedHat/Debian/Ubuntu.
https://galaxy.ansible.com/dj-wasabi/zabbix-server/
MIT License
176 stars 150 forks source link

Install Python bindings based on interpreter; Closes dj-wasabi/ansible-zabbix-server#148 #149

Closed kr4ut closed 5 years ago

kr4ut commented 5 years ago

Description of PR Abstracts the package prefix for Python on Debian to a variable that gets calculated before.

Type of change Bugfix Pull Request

Fixes an issue https://github.com/dj-wasabi/ansible-zabbix-server/issues/148

dj-wasabi commented 5 years ago

Hi @kr4ut

Sorry for late reply. The CI test is failing, can you please take a look and fix it?

Thank you!

kr4ut commented 5 years ago

@dj-wasabi Don't worry about late actually perfectly in time as we started working on revamping our Zabbix infrastructure from today and improving the role internally. But still some prep for more PRs a head and facing a similiar need in ansible-zabbix-web with the whole thingy about:

https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.8.html#python-interpreter-discovery

Guess it fails here as this change is not backward compatible and v2.7 is used in Travis. But needs more review how to solve python vs python3 package selection based on the used interpreter. We ported our stuff already to the future default "auto" and needed this change. But will look those days into it if no one still on <= 2.7 is quicker ...

kr4ut commented 5 years ago

@dj-wasabi Wrong assumption on my side it was actually the set_fact and shell module combination. Please double check but assume this fix doesn't change but keep lint happy.

dj-wasabi commented 5 years ago

Thanks! 👍