search

dj-wasabi / ansible-zabbix-server

Installing and maintaining zabbix-server for RedHat/Debian/Ubuntu.
https://galaxy.ansible.com/dj-wasabi/zabbix-server/
MIT License
176 stars 150 forks source link

Invalid ServerAlias is added to Apache VirtualHost #45

Closed stephankn closed 7 years ago

stephankn commented 7 years ago

An invalid (maybe even harmful) ServerAlias is added:

ServerAlias 2.4

this was introduced here:

https://github.com/dj-wasabi/ansible-zabbix-server/blob/d17069c15ee50aad292c27e470e4fac1544cc68f/templates/apache_vhost.conf.j2#L3

I believe this is useless at this location. Why should my host be called "2.4"?

My suggestion is to completely remove this line.

dj-wasabi commented 7 years ago

Hi @stephankn

I've removed the line. It was indeed not needed.