search

dj51d / cbmcodecs

Python codecs for PETSCII encodings
GNU General Public License v2.0
13 stars 4 forks source link

Incorrect Code Point at 0x60 #1

Closed gitjeff2 closed 6 years ago

gitjeff2 commented 8 years ago

It looks like when Linus Walleij created his PETSCII to Unicode table he made an off-by-one error and that mistake made it into your codec tables.

He defines 0x60 as follows:

0x60    0x2501  #BOX DRAWINGS LIGHT HORIZONTAL

However, "box drawings light horizontal" is 0x2500. (The code point 0x2501 is "box drawings heavy horizontal.") See the Wikipedia article on Box Drawing Characters for details.

Other projects also use 0x2500 for this code point.

irmen commented 6 years ago

@gitjeff2 this is now fixed in my fork of this library

irmen commented 6 years ago

@dj51d merging my PR has resolved this issue now (and issue #3 as well)