search

djacobs / PyAPNs

Python library for interacting with the Apple Push Notification service (APNs)
http://pypi.python.org/pypi/apns/
MIT License
1.22k stars 376 forks source link

(fix) #108: Missing _sent_notifications #109

Open matiboy opened 9 years ago

matiboy commented 9 years ago

Define self._sent_notifications even when not using enhanced. Problem is that _sent_notifications is used in send_notification_multiple since f33faf79de5e36a7b983b0a318bd2a7e7f99e3a7 Fixes #108

jimhorng commented 9 years ago

@matiboy , if not using enhanced, it's meaningless to store sent_notifications since APNS will not respond error on fail-to-sent notification. So I suggest better to remove all enhanced-related logic(e.g. sent_notifications) from non-enhanced code. FYR.

matiboy commented 9 years ago

@jimhorng Ok makes sense. So now it's checking whether we're using enhanced before adding the results to the queue (which was causing the original error). Thanks

jimhorng commented 9 years ago

@djacobs , I think this one is good enough to be merged :+1:

djacobs commented 9 years ago

Thanks @jimhorng - will review shortly!