search

djacobs / PyAPNs

Python library for interacting with the Apple Push Notification service (APNs)
http://pypi.python.org/pypi/apns/
MIT License
1.22k stars 377 forks source link

add title and subtile params for iOS 10 #196

Closed ChaosTong closed 6 years ago

ChaosTong commented 6 years ago

in iOS 10 you can use title and subtitle to make your words like this

2017-07-14 13 58 13
chadham commented 6 years ago

Can we get this pulled please? Thanks

ChaosTong commented 6 years ago

@chadham sure

chadham commented 6 years ago

Hi, am not familiar how GitHub works. Will Jacobs pull your update and commit in his branch?

I'd like to use the title and subtitle in my notifications.

Thanks.

On Tue, Jan 9, 2018 at 6:05 PM, Chaos丶Lonely notifications@github.com wrote:

@chadham https://github.com/chadham sure

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/djacobs/PyAPNs/pull/196#issuecomment-356477190, or mute the thread https://github.com/notifications/unsubscribe-auth/Ahooddwdk_sxMo4N8iHrFZjuKmn2pqfiks5tJBrigaJpZM4OX3Ch .

ChaosTong commented 6 years ago

@chadham i have no idea about that. if you want use this feature you can just change the source code in your project, just 9 lines change you can see it in files changed

chadham commented 6 years ago

I tried that already, but Im not able to build/install via my raspberry pi. Says apyns.py file has null characters - it won't let me compile the original file due to the same error (so Im sure I didn't introduce it by editing in vi).

ChaosTong commented 6 years ago

@chadham you can use it by source code rather than install as module, you did like this. or you install it then change the installed code

chadham commented 6 years ago

Confirmed it works. Thanks very much.

r4m commented 6 years ago

+1 for pulling it thx