search

djacobs / PyAPNs

Python library for interacting with the Apple Push Notification service (APNs)
http://pypi.python.org/pypi/apns/
MIT License
1.22k stars 374 forks source link

Upload New Version To PyPI #205

Open alliefitter opened 6 years ago

alliefitter commented 6 years ago

Ref #63

The current version hosted on PyPi does not have the changes added in fce9e33c62a0cef8eebcd8b1a293d66be0b45480 which make the module compatible with Python 3. Uploading a new version would be greatly appreciated as this is the only maintained Python APNS library I've found. Thanks! (And thanks for maintaining this repository for so many years!)

alliefitter commented 6 years ago

Sorry to bump this, but is there any ETA on a PyPi upload?

Schnodderbalken commented 6 years ago

I would also appreciate the Python 3 compatible version to be published!

laundry-96 commented 5 years ago

Hey, can we get an update to this @djacobs

djacobs commented 5 years ago

I'm open to it, I've not been able to test. The diff appears innocuous. Can folks confirm this is working in production and passes tests?

I agree the right thing to do is to leave old Python behind.

laundry-96 commented 5 years ago

I'm currently in development stages of using this package for a software at work, so no clue what's going to happen. Currently using version 833b00f5c58a211d4a00ee4a0c41ca0a0e032270

djacobs commented 5 years ago

Thanks @laundry-96 - let me know how it goes.

shiyuchong commented 5 years ago

I currently test it on python 3.6, and test failed

FAIL: testFrame (main.TestAPNs)

Traceback (most recent call last): File "tests.py", line 193, in testFrame self.assertTrue(f1 == frame.get_frame() or f2 == frame.get_frame()) AssertionError: False is not true

@djacobs

shiyuchong commented 5 years ago

and others just pass.

shiyuchong commented 5 years ago

OK, I have fixed the bug. just change the order in Payload.dict.

djacobs commented 5 years ago

Thanks, please make a pull request.

shiyuchong commented 5 years ago

@djacobs , Done. But I recommend you test it again in your own computer. I edit it on github, so there maybe problems like indent. Thanks for your work.