search

djacobs / PyAPNs

Python library for interacting with the Apple Push Notification service (APNs)
http://pypi.python.org/pypi/apns/
MIT License
1.22k stars 374 forks source link

Make hosts/ports configurable #22

Closed jacobcr closed 11 years ago

jacobcr commented 11 years ago

In our environment we need to make hosts/ports configurable.

simonwhitaker commented 11 years ago

Hi there. I'm curious; what's the scenario in which you'd need to override the default hosts and ports?

jacobcr commented 11 years ago

I have a complex system with other dependencies, I want to test my system with heavy loads, in a first stage I made tests using mocks directly but know I'm planning to test the entire system using a more real approach, having. This way we can test if our monitor system is working properly, connectivity problems, etc.

simonwhitaker commented 11 years ago

Thanks for explaining. In this case I'm going to decline the pull request as this doesn't sound like functionality that belongs in the core library. You're always free to use a local, tweaked copy of course, or take an alternative approach such as hacking your /etc/hosts.