djacobs / PyAPNs

Python library for interacting with the Apple Push Notification service (APNs)
http://pypi.python.org/pypi/apns/
MIT License
1.22k stars 374 forks source link

added support of enhanced format #24

Closed ghost closed 11 years ago

ghost commented 11 years ago

I made this change a few months ago and have used it since then, but not sure this is kind of well-designed implementation. Using non-blocking socket to send enhanced format APN payload and receive response.

simonwhitaker commented 11 years ago

Thanks for this. I won't accept the pull request because unit tests fail with this change on python 2.5 (see the Travis build output). It also includes changes to README.markdown that I wouldn't want to pull into my repository (change of installation instructions, removal of Travis CI results link, etc). But if you'd care to clean those things up and re-submit I'm certainly open to the general idea.

ghost commented 11 years ago

OK, I will