search

djacobs / PyAPNs

Python library for interacting with the Apple Push Notification service (APNs)
http://pypi.python.org/pypi/apns/
MIT License
1.22k stars 374 forks source link

Include payload size in PayloadTooLargeError #27

Closed sandizzle closed 11 years ago

sandizzle commented 11 years ago

Currently, there is no information about the payload size when a PayloadTooLargeError is raised. It is kind of helpful to know this when an exception is raised so that application developer can use this info for logging or cutting down the payload.

dfujiwara commented 11 years ago

Is there a reason why this is not merged? It seems very useful and I was about to implement a similar feature.

djacobs commented 11 years ago

Looks like this actually just crossed the transition from Simon to myself. I'm happy to merge it, I'll check it out in detail tomorrow. Thanks.

djacobs commented 11 years ago

Assigning to myself to consider the merge.

dfujiwara commented 11 years ago

Cool it will be great if we can get this merged. Let me know if you need any help with it!

dfujiwara commented 11 years ago

@djacobs, was wondering what the status of this pull request.Thanks!