For Enhanced message, add auto close connection when idle to avoid long-term connection error.

djacobs / PyAPNs

Python library for interacting with the Apple Push Notification service (APNs)

http://pypi.python.org/pypi/apns/

MIT License

1.22k stars 376 forks source link

For Enhanced message, add auto close connection when idle to avoid long-term connection error. #78

Closed jimhorng closed 9 years ago

jimhorng commented 10 years ago

Add auto close connection when idle to avoid long-term connection error. Since if connection created and idle for more than 2 hours, the actual connection might broken but python runtime doesn't get informed, it will enter weird state
Add timeout and retry for writing data to socket connection
Refactor: refine log and wrap worker thread as class to improve readability

jimhorng commented 9 years ago

@djacobs Suggest this PR better be merged since socket connection error might occur after long idle time when using enhanced message format, which will then block send notification to function correctly. FYR.

jimhorng commented 9 years ago

This will fix #94

djacobs commented 9 years ago

Thanks, I will review.

thejeff77 commented 9 years ago

I have tested this, and it works. I give a +1! If possible, can you give this merge high priority? Thanks.

wasauce commented 9 years ago

I have tested this too, it works and we are using it in production. Thanks!

On Fri, Oct 17, 2014 at 10:46 AM, jblayney notifications@github.com wrote:

I have tested this, and it works. I give a +1! If possible, can you give this merge high priority? Thanks.

— Reply to this email directly or view it on GitHub https://github.com/djacobs/PyAPNs/pull/78#issuecomment-59549358.

djacobs commented 9 years ago

Thanks for your patience, all.

jimhorng commented 9 years ago

Thank @djacobs for review :)