djanatyn / ssbm-nix

Nix expressions for Super Smash Bros. Melee players.
31 stars 17 forks source link

ssbm.gcc.oc-kmod breaks on 22.05 #25

Closed ursi closed 2 years ago

ursi commented 2 years ago

I had just commented this out since I'm not playing much melee right now, and was just gonna wait for it to be fixed. But I tried again after I saw #24. And since it's still not working for me, I decided to say something.

nix log output:

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/3cv4spr1brhyxb55kbmyhw43narx0c4g-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
building
build flags: SHELL=/nix/store/40iwnlr30ykqm5ynm0bbk6bsjjc750ad-bash-5.1-p16/bin/bash O=\$\(buildRoot\) CC=/nix/store/2hrxwmv8xl4wpgjna5dvypadxqzx9yqw-gcc-wrapper-11.3.0/bin/cc HOSTCC=/nix/sto>
make -C /nix/store/y2pixjhy3229031iw0622aqa3xd5hv8v-linux-5.18-dev/lib/modules/5.18.0/build M=/build/source modules
make[1]: Entering directory '/nix/store/y2pixjhy3229031iw0622aqa3xd5hv8v-linux-5.18-dev/lib/modules/5.18.0/build'
  CC [M]  /build/source/gcadapter_oc.o
/build/source/gcadapter_oc.c: In function 'patch_endpoints':
/build/source/gcadapter_oc.c:40:25: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
   40 |                         int ret = 0;
      |                         ^~~
/build/source/gcadapter_oc.c:45:28: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
   45 |                         if(ret = usb_lock_device_for_reset(adapter_device, NULL)) {
      |                            ^~~
cc1: all warnings being treated as errors
make[2]: *** [/nix/store/y2pixjhy3229031iw0622aqa3xd5hv8v-linux-5.18-dev/lib/modules/5.18.0/source/scripts/Makefile.build:288: /build/source/gcadapter_oc.o] Error 1
make[1]: *** [/nix/store/y2pixjhy3229031iw0622aqa3xd5hv8v-linux-5.18-dev/lib/modules/5.18.0/source/Makefile:1834: /build/source] Error 2
make[1]: Leaving directory '/nix/store/y2pixjhy3229031iw0622aqa3xd5hv8v-linux-5.18-dev/lib/modules/5.18.0/build'
make: *** [Makefile:6: all] Error 2
djanatyn commented 2 years ago

Taking a look, thank you for the logs!

ursi commented 2 years ago

I rebuilt today and it was no longer broken.

neonfuz commented 2 years ago

I haven't really done any deep digging but scanning my system logs it looks like the module has been working fine for me for a bit.

ursi commented 2 years ago

Alright, I'll close this then.