django-blog-zinnia / cmsplugin-zinnia

Bridge between django-blog-zinnia and django-cms
BSD 3-Clause "New" or "Revised" License
53 stars 46 forks source link

using cmsplugin-zinnia with django-modeltranslation #2

Closed Lacrymology closed 10 years ago

Lacrymology commented 12 years ago

This is copied verbatim from the email, sorry

Hello, I've been trying to make the cms-plugin able entry model in cmsplugin-zinnia translatable via django-modeltranslation.

I've ended up having to patch for so many incompatibilities that I'm almost thinking I'd better just throw cmsplugin-zinnia away and make my own model with simpletranslation, which is django-cms standard translation system, but I think that'd require massive template adjustments.

So, I wonder if any cares to take a look at all I've had to do, and maybe point out some better ways of fixing some issues (there's even a metaclass)

here are the model and the admin files.

Lacrymology commented 12 years ago

Here's my new models and admin files https://gist.github.com/3019235

Lacrymology commented 12 years ago

An issue I've ran into:

when the CMSPlugin is created, cms.admin.placeholderadmin.PlaceholderAdmin.add_plugin gets the newly created CMSPlugin's language from get_language_from_request(), so the plugins get registered with language=<request language> regardless of on which placeholder it was created.

I can fix this on my EntryTranslationAdmin.save_model method, but this gets dirtier and dirtier

Lacrymology commented 12 years ago

I modified the gist to add the fix for this issue, but it's an extra hit on the database.. OTOH, it's only when the entry is saved, not critical code..

Fantomas42 commented 10 years ago

Hi,

on the recent version of the cms, the content_placeholder field seems working well with i18n. I think I can close the issue now, but thank for the contribution.

Regards