django-blog-zinnia / cmsplugin-zinnia

Bridge between django-blog-zinnia and django-cms
BSD 3-Clause "New" or "Revised" License
53 stars 46 forks source link

Better help_text for Featured and Offset options #20

Closed Fantomas42 closed 10 years ago

Fantomas42 commented 10 years ago

Because can lead to misunderstanding.

bittner commented 10 years ago

Self-explanatory options do it for Featured, I think.

ad 1) "Show featured entries only" / "Hide featured entries" ad 2) "Number of entries to skip from top of list"

$ git diff
diff --git a/cmsplugin_zinnia/models.py b/cmsplugin_zinnia/models.py
index 279e89f..e88ceb0 100644
--- a/cmsplugin_zinnia/models.py
+++ b/cmsplugin_zinnia/models.py
@@ -23,8 +23,8 @@ class LatestEntriesPlugin(CMSPlugin):
     featured = models.NullBooleanField(
         _('featured'),
         blank=True, null=True,
-        choices=((True, _('Yes')),
-                 (False, _('No'))))
+        choices=((True, _('Show featured entries only')),
+                 (False, _('Hide features entries'))))
     categories = models.ManyToManyField(
         'zinnia.Category', verbose_name=_('categories'),
         blank=True, null=True)
@@ -43,7 +43,7 @@ class LatestEntriesPlugin(CMSPlugin):
         help_text=_('0 means all the entries'))
     offset = models.PositiveIntegerField(
         _('offset'), default=0,
-        help_text=_('offset used to display entries'))
+        help_text=_('number of entries to skip from top of list'))
     template_to_render = models.CharField(
         _('template'), blank=True,
         max_length=250, choices=TEMPLATES,

I'm preparing a pull request.