django-blog-zinnia / cmsplugin-zinnia

Bridge between django-blog-zinnia and django-cms
BSD 3-Clause "New" or "Revised" License
53 stars 46 forks source link

Fix 3 System check warnings in LatestEntriesPlugin model #51

Closed bittner closed 8 years ago

bittner commented 8 years ago

When running python manage.py migrate or python manage.py check on a Django 1.8 project using cmsplugin_zinnia Django issues 3 warnings on the LatestEntriesPlugin model:

System check identified some issues:

WARNINGS:
cmsplugin_zinnia.LatestEntriesPlugin.authors: (fields.W340) null has no effect on ManyToManyField.
cmsplugin_zinnia.LatestEntriesPlugin.categories: (fields.W340) null has no effect on ManyToManyField.
cmsplugin_zinnia.LatestEntriesPlugin.tags: (fields.W340) null has no effect on ManyToManyField.

I have removed the 3 occurences of null=True. We don't need a migration for that, do we?

bittner commented 8 years ago

@Fantomas42 Salut Julien, is this PR okay? Can you accept it?