django-blog-zinnia / cmsplugin-zinnia

Bridge between django-blog-zinnia and django-cms
BSD 3-Clause "New" or "Revised" License
53 stars 46 forks source link

Missing migration for django CMS 3.3.x (and Django 1.8+) #57

Closed bittner closed 7 years ago

bittner commented 7 years ago

Obviously, starting with django CMS 3.3.0 (and Django 1.8+) a change triggers some missing migrations in django-blog-zinnia and cmsplugin-zinnia.

migrate complains

Your models have changes that are not yet reflected in a migration, and so won't be applied. Run 'manage.py makemigrations' to make new migrations, and then re-run 'manage.py migrate' to apply them.

and makemigrations --dry-run shows that migrations for zinnia and cmsplugin_zinnia would be created (in site-packages, obviously).

Update: The migrations related to Zinnia directly (0005_entry_content_placeholder) are only related to EntryPlaceholder. See also #56.

This issue seems to affect django CMS plugins in general, and is dealt with in https://github.com/divio/django-cms/issues/5550.

What needs to be done

The migrations that appear missing should be added to the set of existing migrations. This would be a backward incompatible change, though, breaking compatibility with django CMS < 3.3.0 (and Django < 1.8) as explained in the Divio ticket mentioned above.

Maybe it would make sense to make a name change now (cmsplugin-zinnia -> djangocms-zinnia) to make this break obvious?