CMS toolbar: Check user permissions, disable menu items

django-blog-zinnia / cmsplugin-zinnia

Bridge between django-blog-zinnia and django-cms

BSD 3-Clause "New" or "Revised" License

53 stars 46 forks source link

CMS toolbar: Check user permissions, disable menu items #59

Closed bittner closed 7 years ago

bittner commented 7 years ago

This PR enhances the user experience in the "Zinnia" menu of the CMS toolbar.

Menu items for actions that are not available due to lacking permissions are disabled.
If none of the actions (menu items) are available then the complete "Zinnia" menu is removed from the toolbar.

Note: Disabling the actions not available follows Divio's implementation of the toolbar menus. For a "remove items" based implementation see the first commit of this PR.

bittner commented 7 years ago

:bell: @Fantomas42 Is this PR good for merging? The changes should be non-critical, yet still valuable.

Anything I can do to help you merge it? - Thanks!

bittner commented 7 years ago

This one is a nice user experience improvement. A non-critical, nice enhancement. -- Merge?

bittner commented 7 years ago

Oh, this is nice! :sunny: Now the code is much easier to understand! :ok_hand:

bittner commented 7 years ago

Yay, merged! :tada:

Merci!