search

django-blog-zinnia / cmsplugin-zinnia

Bridge between django-blog-zinnia and django-cms
BSD 3-Clause "New" or "Revised" License
53 stars 46 forks source link

Ignore KeyError thrown by render_placeholder() in Admin #61

Closed bittner closed 7 years ago

bittner commented 7 years ago

This PR applies the same hack as PR #45 for KeyError being thrown by django CMS' render_placeholder in the Admin ('request' is not found as a key in context). Changes seem to be saved normally even with KeyErrors being silently ignored. :anguished:

See also: https://github.com/divio/django-cms/issues/5646

bittner commented 7 years ago

:bell: @Fantomas42 Is this PR good for merging? Would help me if this were merged.

More information / discussion is available in the related Divio issue (linked to above).

bittner commented 7 years ago

@Fantomas42 Would be cool if you could merge this PR. Thanks!