triv: fixed subject location on new images

django-cms / django-filer

File and Image Management Application for django

https://django-filer.readthedocs.io/

Other

1.73k stars 575 forks source link

triv: fixed subject location on new images #1276

Closed viliammihalik closed 1 year ago

viliammihalik commented 2 years ago

Description

https://github.com/django-cms/django-filer/issues/1275

Related resources

https://github.com/django-cms/django-filer/issues/1275

Checklist

[x] I have opened this pull request against master
[ ] I have added or modified the tests when changing logic
[x] I have followed the conventional commits guidelines to add meaningful information into the changelog
[x] I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

marksweb commented 2 years ago

Please run the tox tests to verify that tests pass.

viliammihalik commented 2 years ago

It is still not working. I need to add it only to ImageAdmin because anywhere else it is affecting other parts of code.

viliammihalik commented 2 years ago

@marksweb I don't know how to fix this. There is a problem that, if you upload an image from folder admin, all images have subjection location == ''(empty string). Then if you go to detail of the image, empty input is filled by focal-point.js, and value is submitted together with an eventually new uploaded image with subject_location for old image(filled from JS). I am not able to tell at the backend if input was filled by used or by focal-point.js.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This will now be closed due to inactivity, but feel free to reopen it.