feat: Django 4 support - Githubissues

django-cms / django-filer

File and Image Management Application for django

https://django-filer.readthedocs.io/

Other

1.73k stars 575 forks source link

feat: Django 4 support #1281

Closed marksweb closed 1 year ago

marksweb commented 2 years ago

Description

Add testing against django 4

Drops support for old python and django.

Addresses #1279

Checklist

[x] I have opened this pull request against master
[ ] I have added or modified the tests when changing logic
[x] I have followed the conventional commits guidelines to add meaningful information into the changelog
[x] I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

fsbraun commented 2 years ago

@marksweb I just found two more changes needed for Django 4:

In folderadmin.py: ungettext needs to be replaced by ngettext

In folgeradmin.py: Imports from django.utils.http need to be replaced by

  from urllib.parse import quote as urlquote
  from urllib.parse import unquote as urlunquote

In folgermodels.py: from urllib.parse import quote as urlquote

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This will now be closed due to inactivity, but feel free to reopen it.