django-cms / django-filer

File and Image Management Application for django
https://django-filer.readthedocs.io/
Other
1.73k stars 574 forks source link

Fix popup window name to element id transform #1326

Closed stefanw closed 1 year ago

stefanw commented 1 year ago

Description

Django 4.1 adds a popup index to the admin popup window name that needs to be stripped when getting back to the element id.

This should be backwards compatible to previous element ids unless they use double underscores (__) in them.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #1326 (26e4895) into master (62551a1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1326   +/-   ##
=======================================
  Coverage   72.21%   72.21%           
=======================================
  Files          72       72           
  Lines        3239     3239           
  Branches      468      468           
=======================================
  Hits         2339     2339           
  Misses        734      734           
  Partials      166      166           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fsbraun commented 1 year ago

Could that be the root cause of #1317 ?

stefanw commented 1 year ago

Yes, sounds very much like what I experienced.

fsbraun commented 1 year ago

Well spotted!! Thank you!