fix: issues with filer image crash when trying to generate thumbnail

django-cms / django-filer

File and Image Management Application for django

https://django-filer.readthedocs.io/

Other

1.73k stars 574 forks source link

fix: issues with filer image crash when trying to generate thumbnail #1380

Closed vinitkumar closed 12 months ago

vinitkumar commented 12 months ago

Thumbnail generation can fail when the image is not present or moved or if we have a reference in database but no image in storage.

Github Issue: Fixes #1379

Checklist

[x] I have opened this pull request against master
[x] I have added or modified the tests when changing logic
[x] I have followed the conventional commits guidelines to add meaningful information into the changelog
[x] I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

codecov[bot] commented 12 months ago

Codecov Report

Merging #1380 (c79046d) into master (ed50e2d) will decrease coverage by 0.06%. The diff coverage is 12.50%.

@@            Coverage Diff             @@
##           master    #1380      +/-   ##
==========================================
- Coverage   73.64%   73.58%   -0.06%     
==========================================
  Files          75       75              
  Lines        3426     3430       +4     
  Branches      551      551              
==========================================
+ Hits         2523     2524       +1     
- Misses        732      735       +3     
  Partials      171      171

Impacted Files	Coverage Δ
filer/admin/fileadmin.py	`78.16% <12.50%> (-2.57%)`	:arrow_down:

fsbraun commented 12 months ago

@vinitkumar I know I should have done it: Let us create a few tests for the icon_view... Please feel free to include them in this PR or let me know, and I'll add a separate PR.

vinitkumar commented 12 months ago

@fsbraun I will try to get the test done tonight.