django-cms / django-filer

File and Image Management Application for django
https://django-filer.readthedocs.io/
Other
1.76k stars 577 forks source link

fix: try and prevent crash from missing file when thumbnailing #1388

Closed vinitkumar closed 1 year ago

vinitkumar commented 1 year ago

Description

Fix crash in filer performing easy-thumbnails thumb-nailing when for some reason the image is not present.

An earlier fix #1379 was done, but it didn't take care of all edge cases, but this one does and gracefully rescues the error and at the same time provides a fallback.

Related resources

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #1388 (99f71a5) into master (71d16ca) will decrease coverage by 0.18%. The diff coverage is 30.76%.

@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
- Coverage   73.98%   73.80%   -0.18%     
==========================================
  Files          75       75              
  Lines        3436     3443       +7     
  Branches      552      552              
==========================================
- Hits         2542     2541       -1     
- Misses        722      731       +9     
+ Partials      172      171       -1     
Impacted Files Coverage Δ
filer/templatetags/filer_admin_tags.py 84.11% <25.00%> (-6.89%) :arrow_down:
filer/__init__.py 100.00% <100.00%> (ø)