django-cms / django-filer

File and Image Management Application for django
https://django-filer.readthedocs.io/
Other
1.76k stars 577 forks source link

Fix copy folder being broken after django-mptt removal #1393

Closed protoroto closed 1 year ago

protoroto commented 1 year ago

Description

After django-mptt removal, copying folders is broken because insert_at method is not there anymore. I've added a regression test that should show the error, and then a fix for it that make the test pass.

Related resources

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #1393 (a9856c4) into master (83e209f) will increase coverage by 0.61%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1393      +/-   ##
==========================================
+ Coverage   74.16%   74.78%   +0.61%     
==========================================
  Files          75       75              
  Lines        3445     3442       -3     
  Branches      553      553              
==========================================
+ Hits         2555     2574      +19     
+ Misses        720      698      -22     
  Partials      170      170              
Impacted Files Coverage Δ
filer/admin/folderadmin.py 75.18% <100.00%> (+2.50%) :arrow_up:

... and 1 file with indirect coverage changes