Closed misli closed 5 months ago
Attention: 8 lines
in your changes are missing coverage. Please review.
Comparison is base (
dbeda3a
) 75.22% compared to head (cba2715
) 75.09%. Report is 16 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
filer/management/commands/import_files.py | 0.00% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @misli ! Thank you for the pull request.
Can you elaborate on the issue? Why are existing files detected wrongly?
From the code I see, you allow to have multiple files with the same name in the same folder but then ignore all of them but the first. To me it is not immediately transparent why this should be the right way to go. But then again, I have not fully understood the issue.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This will now be closed due to inactivity, but feel free to reopen it.
Description
The
import_files
command tries to skip existing files, but it always create new one, because the way it detects the existing one is wrong.Related resources
Checklist
master