In the CMS admin, when listing the files, we have up to 4 action buttons, with the two firsts "URL" & "Download".
Before this change : Both were links (one canonical, one to the file in media).
Now both are download links.
IMHO :
the "download" attribute on the "canonical url" action, is a mistake and should not be added.
the "download" attribute on the "download" action, is a good and correct improvement to the code.
It became more difficult to display the file in the browser without downloading it. (Now only "right click > open url" allows it.)
So this PR fixes this accordingly.
Also, I noted that the feature name adding the bug was "Styling update", but this change was more a behavior update, I think. So I didn't add anything to the changelog of my PR because it's more "going back to the documented state". However, it might be relevant to document somewhere that the previous version added the download attribute on the download link.
fsbraun
commented
9 months ago
Description
In the CMS admin, when listing the files, we have up to 4 action buttons, with the two firsts "URL" & "Download".
Before this change : Both were links (one canonical, one to the file in media).
Now both are download links.
IMHO :
It became more difficult to display the file in the browser without downloading it. (Now only "right click > open url" allows it.)
So this PR fixes this accordingly.
Also, I noted that the feature name adding the bug was "Styling update", but this change was more a behavior update, I think. So I didn't add anything to the changelog of my PR because it's more "going back to the documented state". However, it might be relevant to document somewhere that the previous version added the download attribute on the download link.