django-cms / django-filer

File and Image Management Application for django
https://django-filer.readthedocs.io/
Other
1.73k stars 574 forks source link

fix: Compatibility with custom images #1454

Closed W1ldPo1nter closed 3 months ago

W1ldPo1nter commented 3 months ago

Description

Fixes the issue mentioned below. As suggested in that thread, I moved the generation of the expand link into the Python code, so that it gets passed to the template via context (which also moves logic from the template to the view layer, which should be a good thing).

While implementing the fix and testing via tox, I found that:

Therefore, I took the liberty to fix the mentioned command and extended the test action matrix with a flag for the image model swap (similar to the tox setup), so that problems with a custom image model have a chance to be caught automatically.

Related resources

Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.90%. Comparing base (b0f39ab) to head (acd03e8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1454 +/- ## ========================================== + Coverage 76.59% 76.90% +0.31% ========================================== Files 75 75 Lines 3546 3551 +5 Branches 568 570 +2 ========================================== + Hits 2716 2731 +15 + Misses 667 660 -7 + Partials 163 160 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.