django-cms / django-filer

File and Image Management Application for django
https://django-filer.readthedocs.io/
Other
1.77k stars 580 forks source link

'AdminSite' object has no attribute 'root_path' #173

Closed mmarzantowicz closed 12 years ago

mmarzantowicz commented 12 years ago

Problem was found when using:

Django 1.4b Filer 0.9a1

There seems to be no attribute 'root_path' in AdminSite anymore (see: https://code.djangoproject.com/changeset/16575) but it is used in filer/admin/folderadmin.py in directory_listing, line 357.

Error occurs when attempting to access Filer->Folders from djnago admin site.

mmarzantowicz commented 12 years ago

I did a little experiment on this issue and commented all lines with root_path in folderadmin.py. They are used in render_to_response as extra context variables and it looks like they are useless. I'm able to view the requested admin page.

root_path is not used in django.contrib.admin (I did grep on django files from trunk). It is not clear for me if this variable is really needed in previous django releases (e.g current 1.3.1).

marconius commented 12 years ago

root_path has been removed: Removed deprecated admin contrib app AdminSite root_path attribute. Refs #15294, r11250, r16136

yakky commented 12 years ago

Looks like it has been fixed by #175

yakky commented 12 years ago

Closed as fixed by #175