search

django-cms / djangocms-admin-style

django CMS Admin Style is a Django Theme tailored to the needs of django CMS.
http://www.django-cms.org/
Other
418 stars 118 forks source link

Fix modals layout issues with Django 3.1 #432

Closed yakky closed 3 years ago

yakky commented 3 years ago

Django 3.1 introduced a sidebar that is visible in the django CMS toolbar modals

Before

Screenshot_20201221_125435_2

After

Screenshot_20201221_125406

Aiky30 commented 3 years ago

@yakky Did you check this change with Django 2.2 i.e. sanity check?

yakky commented 3 years ago

@yakky Did you check this change with Django 2.2 i.e. sanity check?

yes, there is no conflict (mostly because the hidden elements has been introduced in Django 3.1)

Checked also in django CMS 3.7

codecov-io commented 3 years ago

Codecov Report

Merging #432 (d42efc7) into master (e7e59d5) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #432   +/-   ##
=======================================
  Coverage   34.28%   34.28%           
=======================================
  Files           1        1           
  Lines          35       35           
  Branches        1        1           
=======================================
  Hits           12       12           
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7e59d5...d42efc7. Read the comment docs.