search

django-cms / djangocms-admin-style

django CMS Admin Style is a Django Theme tailored to the needs of django CMS.
http://www.django-cms.org/
Other
412 stars 116 forks source link

Header box-shadow missing (CSS variables do not work in rgba) #450

Closed petrklus closed 2 years ago

petrklus commented 2 years ago

The box-shadow seems to be broken in 3.1.0:

image

When inspecting, seems that the colour is not being picked up:

image

While in 3.0.0, it is resolved into a colour:

image

I believe that this construct is not valid:

rgba(var(--dca-black), 0.2, which results from https://github.com/django-cms/djangocms-admin-style/blob/f026ee564f11600c033b1a73192c80fad3d51833/djangocms_admin_style/sass/settings/_cms.scss#L234

The solution is to either hard-code the colour value, or to define colours with alpha in them and then use them throughout.

I believe this would also affect $hover-tooltip-bgcolor, $dropdown-shadow and many others that now use CSS variables inside the rgba construct.

Tested on Mac OS 10.15.7, Chrome 100.0.4896.60

petrklus commented 2 years ago

@fsbraun I belive the above is related to the dark mode introduction, which changed the simple black/white colours (which worked in rgba construct) to CSS variables, which do not seem to resolve.

Would you be up for a new PR/amending yours to fix the above?

fsbraun commented 2 years ago

@petrklus I will look into it. Anyways, the shadows should have stayed black. Otherwise you'll get white shadows in dark mode which is strange. Will also check if other shadows might be affected. Thanks for pointing this out!

petrklus commented 2 years ago

Thank you @fsbraun ! Will keep an eye on the PR and test once released.