search

django-cms / djangocms-admin-style

django CMS Admin Style is a Django Theme tailored to the needs of django CMS.
http://www.django-cms.org/
Other
412 stars 116 forks source link

Fix: Missing drop shadows and unreadable button coloring on hover #451

Closed fsbraun closed 2 years ago

fsbraun commented 2 years ago

This PR fixes #450 and another bug which renders some button unreadable (same fore and background color) when hovered.

Drop shadows do not change color in dark mode (since shadows are not white!). They have and should have hard-coded colors (black in this case).

At the same time the deprecated sass operator / has been replaced by the supported math.div function.

codecov-commenter commented 2 years ago

Codecov Report

Merging #451 (d6bde16) into master (894527c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   36.11%   36.11%           
=======================================
  Files           2        2           
  Lines          36       36           
  Branches        1        1           
=======================================
  Hits           13       13           
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 894527c...d6bde16. Read the comment docs.