fix: Remove unused icon css

[fsbraun]

djangocms-admin-style adds its own icon font (for the well-known symbols to add etc.). Besides providing css to style the admin the package adds css to allow using those icons by other apps in the admin.

• The use is deprecated since the djangocms-admin-style package is optional and hence the availability of the icon css on admin pages is not guaranteed.
• Over time the icons (both in terms of which and how they look) have stated deviating from the django-cms core's icons.
• This the same icons are at different positions in the icon fonts.

This PR removes the css for using the djangocms-admin-style icons in other apps to avoid the conflict between the icon positions. The icons themselves remain untouched and will appear as usual.

[codecov[bot]]

Codecov Report

Merging #472 (457617f) into master (d19362f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   34.28%   34.28%           
=======================================
  Files           1        1           
  Lines          35       35           
  Branches        1        1           
=======================================
  Hits           12       12           
  Misses         23       23           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[fsbraun]

Thanks!

[DmytroLitvinov]

Hi @marksweb , We are still using djangocms-admin-style and django-admin-shortcuts and we found out that starting version 3.2.1 shortcuts are not aligned. Can we move back @import "components/shortcuts"; into a new version? The solution I used to make it work for us was taken from that issue https://github.com/alesdotio/django-admin-shortcuts/issues/34

P.S. In case if someone needs same solution, you can take a look it here

[marksweb]

@DmytroLitvinov Is components/shortcuts specific to icons in that package?

[DmytroLitvinov]

Seems like not. So I think icon function can be removed file components/shortcuts

[fsbraun]

@DmytroLitvinov Thanks for pointing out this issue!

Can you check if this solution works for you: Replace the djangocms-admin-style requirement by git+https://github.com/fsbraun/djangocms-admin-style@fix/django_shortcuts ?

It includes the styling but not the icons.

If it works, I can immediately create the PR.

[DmytroLitvinov]

@fsbraun ,

Yes, it works 👍

[fsbraun]

@DmytroLitvinov See #480 and #481