django-cms / djangocms-admin-style

django CMS Admin Style is a Django Theme tailored to the needs of django CMS.
http://www.django-cms.org/
Other
411 stars 116 forks source link

feat: Add Django 4.2 admin support #500

Closed fsbraun closed 6 months ago

fsbraun commented 8 months ago

Django admin styles have changed. This fixes the delete-link styling and the readonly-fields styling

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ae6ec18) 100.00% compared to head (9c7ba4b) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #500 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 33 33 Branches 3 3 ========================================= Hits 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DmytroLitvinov commented 6 months ago

Hi @fsbraun , Seems like that Pull Request can fix issue we have at our stage server when we upgraded to Django@4.2 and we have read-only fields.

I will look into details and let you know if it fixes so we can merge and release new version of djangocms-admin-style

DmytroLitvinov commented 6 months ago

@fsbraun , should it looks like that way?

image
fsbraun commented 6 months ago

@DmytroLitvinov IMHO it should look like a form with editable fields, but the inputs replaced by the fields' values. Would you expect something else?

DmytroLitvinov commented 6 months ago

For me it is fine that it looks like that way.

Also attaching how it looks for Django@4.2 without djangocms-admin-style image

fsbraun commented 6 months ago

Yes, plain django admin style uses horizontal separation on large screens and vertical separation of label and field on small screens.

@vinitkumar OK for you, too? Can you review? 😎